Skip to content

point to the pinning reference instead of the tutorial #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

point to the pinning reference instead of the tutorial #753

wants to merge 1 commit into from

Conversation

fricklerhandwerk
Copy link
Collaborator

No description provided.

@fricklerhandwerk fricklerhandwerk requested a review from a team as a code owner October 9, 2023 15:52
infinisil
infinisil requested changes Oct 9, 2023
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this. There's no link back from the reference on pinning to the pinning tutorial. I think either that should be added, or we should keep linking to the tutorial (which does link to the reference).

@fricklerhandwerk
Copy link
Collaborator Author

We should merge these two anyway, since the "tutorial" doesn't really have much information: #750

This PR is preparation for that.

@infinisil
Copy link
Member

Feels like this should just be a commit in a PR that does the pinning revising then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fricklerhandwerk @infinisil